This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 889
Added allow-generics option to invalid-void rule #4839
Merged
adidahiya
merged 6 commits into
palantir:master
from
JoshuaKGoldberg:invalid-void-generics
Sep 9, 2019
Merged
Added allow-generics option to invalid-void rule #4839
adidahiya
merged 6 commits into
palantir:master
from
JoshuaKGoldberg:invalid-void-generics
Sep 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
suggested changes
Sep 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, let's just improve the error messages a bit
Thanks! Co-Authored-By: Adi Dahiya <adi.dahiya14@gmail.com>
Thanks @adidahiya - sorry about the delay! |
adidahiya
approved these changes
Sep 9, 2019
This was referenced Nov 13, 2019
This was referenced Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
invalid void
#4828Overview of change:
Adds an
allow-generics
option toinvalid-void
for the sake of common uses such asPromise<void>
. It'strue
by default, can be specified asfalse
, and also allows astring[]
whitelist: e.g."allow-generics": ["Promise"]
.CHANGELOG.md entry:
[new-rule-option]: Added allow-generics to invalid-void