This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Bumped supported versions of Node and TypeScript in CircleCI #4916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
reviewed
Mar 2, 2020
|
I think this ranks up there with one of the most amusing open source CircleCI flows I've seen in a JavaScript/Node project...
|
|
@adidahiya I'm wondering if we could get away with maybe a third of those languages... say, 3.1, 3.4, and 3.8? Edit: ended up removing a bunch. |
adidahiya
approved these changes
Mar 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
[ ] New feature, bugfix, or enhancement[ ] Includes tests[ ] Documentation updateOverview of change:
Removes the now-EOL Node 6 from CircleCI, and explicitly adds TypeScript versions 3.1-3.8 to tests.
I noticed
appveyor.ymlis still hanging around, so I removed that too.