Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AuditLogV3 to switch to less-nested fields by removing unusable SensitivityTaggedValue levels in a non-breaking way. #831

Closed
wants to merge 1 commit into from

Conversation

ganelo
Copy link
Contributor

@ganelo ganelo commented Jun 12, 2024

In practice, SensitivityTaggedValue.level was always being set to unknown, which makes the nesting somewhat pointless. Adding new, unnested fields here in support of eventually removing the old ones entirely without breaking consumers in the meantime.

…e SensitivityTaggedValue levels in a non-breaking way.
@changelog-app
Copy link

changelog-app bot commented Jun 12, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Update AuditLogV3 to switch to less-nested fields by removing unusable SensitivityTaggedValue levels in a non-breaking way.

Check the box to generate changelog(s)

  • Generate changelog entry

@ganelo ganelo requested a review from sfackler June 12, 2024 19:37
@ganelo
Copy link
Contributor Author

ganelo commented Jun 12, 2024

Closing in favor of PR directly in original repo w/o fork.

@ganelo ganelo closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants