Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send shutdown event when shutting down #20

Closed
farao opened this issue May 24, 2020 · 3 comments · Fixed by #24
Closed

Send shutdown event when shutting down #20

farao opened this issue May 24, 2020 · 3 comments · Fixed by #24

Comments

@farao
Copy link
Member

farao commented May 24, 2020

When the signal tower is shut down, according to the palava protocol a shutdown event shall be sent:

{
  event: 'shutdown'
}
@farao
Copy link
Member Author

farao commented May 31, 2020

This should have a test (especially since I'm not 100% sure if the events will "make it out" before the application is killed). I added another issue for adding integration tests: #26

@farao
Copy link
Member Author

farao commented Jun 1, 2020

Yeah, I think I would leave that out and rather not let a shutdown/restart of the palava server happen too often :D

@farao farao closed this as completed in #24 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants