Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests #26

Open
farao opened this issue May 31, 2020 · 0 comments
Open

Add integration tests #26

farao opened this issue May 31, 2020 · 0 comments

Comments

@farao
Copy link
Member

farao commented May 31, 2020

Right now, the websocket handler is completely untested because we have only tests for the session (already a bit integration test because instead of mocking, this tests the workflow user sessions -> room -> user sessions) and more unit like tests for a room.

This would need:

  1. choosing an elixir websocket library
  2. connecting to the signaltower via network/websocket
  3. sending json strings - maybe we just replicate the session tests in this form?
  • should also tests functions that are only in the websocket handler and e.g. also that shutdown messages are sent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant