Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Toggles focusable from the keyboard #38

Closed
4 tasks done
palcarazm opened this issue Jul 17, 2022 · 1 comment · Fixed by #41
Closed
4 tasks done

[FEATURE] Toggles focusable from the keyboard #38

palcarazm opened this issue Jul 17, 2022 · 1 comment · Fixed by #41
Assignees
@palcarazm
Labels
enhancement New feature or request
Milestone
v4.3.0

Comments

@palcarazm
Copy link
Owner

palcarazm commented Jul 17, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
When filling in a basic HTML form, some users prefer to use only the keyboard, tabbing through the fields and entering values.

Describe the solution you'd like

  • Add to toggle elements a tab index 0 to be focusable from the keyboard.
  • Add styling to focused toggle elements to show when they're focused.

Describe alternatives you've considered
😞

Additional context
Original from :

☑️ Task list

  • Develop feature/fix jQuery
  • Develop feature/fix ECMAS
  • Add cypress test coverage
  • Update docs (is needed)
@palcarazm palcarazm added the enhancement New feature or request label Jul 17, 2022
@github-actions
Copy link

Hi! 👋
Thanks for your issue. You are helping to improve Bootstrap 5 toggle.

@palcarazm palcarazm added this to the v4.3.0 milestone Jul 17, 2022
Repository owner deleted a comment from github-actions bot Jul 17, 2022
@palcarazm palcarazm self-assigned this Jul 17, 2022
palcarazm added a commit that referenced this issue Jul 17, 2022
@palcarazm
feat: Toggles focusable from the keyboard
2255f47 
- By default tabindex is set to 0
- The tabindex attribute of the checkbox is propagated to the toggle

Refs: Closes #38
palcarazm added a commit that referenced this issue Jul 17, 2022
@palcarazm
test: Add coverage to toggle focusable
70df8b3 
Refs: #38
palcarazm added a commit that referenced this issue Jul 17, 2022
@palcarazm
docs: Add tabindex options
6274bd8 
Refs: #38
@palcarazm palcarazm mentioned this issue Jul 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palcarazm palcarazm

Labels
enhancement New feature or request
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging a pull request may close this issue.

feat: Toggles focusable from the keyboard palcarazm/bootstrap5-toggle
1 participant
@palcarazm