-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] 'Empty string passed to getElementById().' warning on Firefox. #80
Comments
Hi! 👋 |
Hi @DarkNami , Thanks for the issue 😊. If you can do a PR so you will be listed as controntibutor. |
Hi @palcarazm , I am not familiar with GitHub. 😵 I have tried to fork your repositorie |
Okay, don't worry. I will merge your changes and put you as co-author of the commit. |
Thank you. 👍 |
fix: Remove attribute for if there is no ID (#80)
Done! It will be released in the next patch. |
I have tested it, warning is stopped. |
fix: Remove attribute for if there is no ID Fixes (#80)
Describe the bug
If the
<input>
has not setID
attribute, it will cause 'Empty string passed to getElementById().' warning on Firefox.To Reproduce
Steps to reproduce the behavior and minimal code:
Expected behavior
Don't add
for
attribute if attributeID
does not exist.Screenshots
Desktop:
Additional context
I had fix this issue for old bootstrap4-toggle on my fork.
DarkNami@76fb0c1
Do you need I create a PR for this issue or palcarazm can fix it ? (it is short, only 4 lines changes.)
The text was updated successfully, but these errors were encountered: