Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Change toggleOn and toggleOff elements from label to span #96

Closed
palcarazm opened this issue Dec 26, 2022 · 2 comments · Fixed by #101
Closed

[FEATURE] Change toggleOn and toggleOff elements from label to span #96

palcarazm opened this issue Dec 26, 2022 · 2 comments · Fixed by #101
Assignees
@palcarazm
Labels
enhancement New feature or request
Milestone
v5.0.0-alpha

Comments

@palcarazm
Copy link
Owner

No description provided.

@palcarazm palcarazm added the enhancement New feature or request label Dec 26, 2022
@palcarazm palcarazm added this to the v5.0.0-alpha milestone Dec 26, 2022
@github-actions
Copy link

Hi! 👋
Thanks for your issue. You are helping to improve Bootstrap 5 toggle.

@github-actions
Copy link

github-actions bot commented Dec 26, 2022 •
edited by palcarazm
Loading

☑️ Task list

  • Develop feature/fix jQuery
  • Develop feature/fix ECMAS
  • Add cypress test coverage
  • Update docs (is needed)

@palcarazm palcarazm self-assigned this Dec 28, 2022
palcarazm added a commit that referenced this issue Dec 28, 2022
@palcarazm
feat!: Change toggleOn and toggleOff elements from label to span Closes
3463f02 
#96

BREAKING CHANGE: Custom styles can be affected. Consider to use the class and not the element for style definition.
@palcarazm palcarazm linked a pull request Dec 28, 2022 that will close this issue
feat!: Change toggleOn and toggleOff elements from label to span Closes #96 #101
Merged
palcarazm added a commit that referenced this issue Dec 28, 2022
@palcarazm
Merge pull request #101 from palcarazm:palcarazm/issue96
0afc68a 
feat!: Change toggleOn and toggleOff elements from label to span Closes #96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palcarazm palcarazm

Labels
enhancement New feature or request
Projects
Issue triage
Archived in project
Milestone
v5.0.0-alpha
1 participant
@palcarazm