Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Change on and off options to onlabel and offlabel #99

Closed
palcarazm opened this issue Dec 26, 2022 · 2 comments · Fixed by #100
Closed

[FEATURE] Change on and off options to onlabel and offlabel #99

palcarazm opened this issue Dec 26, 2022 · 2 comments · Fixed by #100
Assignees
@palcarazm
Labels
enhancement New feature or request
Milestone
v5.0.0-alpha

Comments

@palcarazm
Copy link
Owner

No description provided.

@palcarazm palcarazm added the enhancement New feature or request label Dec 26, 2022
@palcarazm palcarazm added this to the v5.0.0-alpha milestone Dec 26, 2022
@github-actions
Copy link

github-actions bot commented Dec 26, 2022 •
edited by palcarazm
Loading

☑️ Task list

  • Develop feature/fix jQuery
  • Develop feature/fix ECMAS
  • Add cypress test coverage
  • Update docs (is needed)

@github-actions
Copy link

Hi! 👋
Thanks for your issue. You are helping to improve Bootstrap 5 toggle.

@palcarazm palcarazm self-assigned this Dec 26, 2022
palcarazm added a commit that referenced this issue Dec 26, 2022
@palcarazm
feat!: Change on and off option to onlabel and offlabel Closes #99
a6c8e3b 
BREAKING CHANGE: on and off API option and data-attribute will throw a warning.
palcarazm added a commit that referenced this issue Dec 26, 2022
@palcarazm
test: Update test to consider feature #99.
f8f0a3c 
- Update custom text  and api contrusctor tests
- Add test for deprecation warning
@palcarazm palcarazm linked a pull request Dec 26, 2022 that will close this issue
feat!: Change on and off option to onlabel and offlabel Closes #99 #100
Merged
palcarazm added a commit that referenced this issue Dec 26, 2022
@palcarazm
Merge pull request #100 from palcarazm:palcarazm/issue99
2d5dbaa 
feat!: Change on and off option to onlabel and offlabel Closes #99
palcarazm added a commit that referenced this issue Dec 27, 2022
@palcarazm
docs: Change on and off options to onlabel and offlabel
640c700 
Refs: #99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palcarazm palcarazm

Labels
enhancement New feature or request
Projects
Issue triage
Archived in project
Milestone
v5.0.0-alpha
Development

Successfully merging a pull request may close this issue.

feat!: Change on and off option to onlabel and offlabel Closes #99 palcarazm/bootstrap5-toggle
1 participant
@palcarazm