Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lift update on undefined #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make lift update on undefined #133

wants to merge 1 commit into from

Conversation

fabid
Copy link

@fabid fabid commented Jan 5, 2017

Both flyd.map and flyd.merge functions are updating when the argument function returns undefined.

In order to be consistent, I think this should also be applied to the lift function.

I changed the behaviour and added a test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4d396b6 on fabid:lift-undefined into 7ffd1fd on paldepind:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4d396b6 on fabid:lift-undefined into 7ffd1fd on paldepind:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabid @coveralls