-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert $width
to character before calling replace_na()
#35
Convert $width
to character before calling replace_na()
#35
Conversation
Hi @palderman, were you planning on doing a CRAN release soon? Your package still shows up in our revdepchecks and we are getting closer to release! Thanks! |
@palderman it seems like this patch did not make it into your 0.0.5 release. If you download the latest release from CRAN and run the code at the code of this PR then you get the same issue, and it looks like the source code on CRAN doesn't have the patch even though the GitHub code does. Did it get lost somehow? We plan to release tidyr this week! |
@DavisVaughan ,🤦Don't know what happened. I'll fix it and get the correct version submitted ASAP. |
You may have forgotten to pull in the changes locally on your laptop after merging |
Proper version has now been submitted to CRAN. Apologies for the delay. I think what happened is I accepted your pull request into the main branch, but inadvertently submitted the develop branch to CRAN. In any case, all should be well shortly. |
We are updating
tidyr::replace_na()
to utilize vctrs, and that results in slightly stricter / more correct type conversions. See tidyverse/tidyr#1219We noticed in revdeps that this package broke. An easy way to see this is by installing the PR mentioned above and running:
The problem boils down to the fact that you are calling
replace_na(.data$width, replace = "")
, butwidth
is a numeric column, not a character column. It looks like you really do wantwidth
to be a character column for usage inglue_data()
later, so I have preemptively coerced it for you beforereplace_na()
is called.We would greatly appreciate if you could merge this PR and submit a patch release of your package to CRAN so we can send tidyr in!