Add DataTypeExt and FieldExt to assist converting to/from Fields and … #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Oct 22, 2025
| true, | ||
| ) | ||
| .into()) | ||
| Ok(self.convert_data_type_to_field(inner_sql_type)?.into_list()) |
There was a problem hiding this comment.
The point of the PR is to move a bunch of the replicated code so that it becomes easier to understand what is going on rather than be overwhelmed in the mechanics of coversion
|
FYI @paleolimbot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed extension to apache#17986
It doesn't have to be added to that PR (I can make a follow on PR to clean up)
The idea is to help ease the transition from DataType to Fields by encapsulating a bunch of the mechanics of converting to/from Fields and DataTypes