CMake script improvements (compat with s2 v0.11) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reusing the project in downstream projects
martinfleis
reviewed
Aug 14, 2024
Not really useful (not sure anyone wants to build tests with coverage *and* install the library at the same time) but should probably fix CI.
This is fine with my usage (we're about to finally update the s2 version in the R package), but it might be worth keeping the defines (or a comment explaining that this bit of code would need to change if using an older version). |
|
Cool thanks! Any objections if I cut a 0.1.1 release after merging this PR? It will help me moving forward with packaging in Spherely. |
I went ahead and published https://github.com/paleolimbot/s2geography/releases/tag/0.1.1 (hope you don't mind!) |
|
And released https://github.com/paleolimbot/s2geography/releases/tag/0.1.2 (sorry!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates to the cmake script(s):
S2_SOURCE=BUNDLEoption.S2_SOURCE=BUNDLEoption (closes Noisy Tests Build #14)@paleolimbot @pramsey I had to add some (quite ugly) workarounds to make #13 work (
S2_VERSION_**were undefined so the old definition ofS2CellRelationwas still selected even with s2 v0.11). As you mentioned there is still no easy way to get the version of s2 when it is found viafind_package(). I'm not sure that requiring the user to manually specify the version (e.g., as a cmake option) would be better.To make things easier to maintain, I'm wondering if we couldn't just drop supporting versions of s2 < 0.11? For my usage (Python / spherely) that would be fine. What about your usage? Any thoughts?