PolygonGeography default constructor: create empty S2Polygon #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been struggling a bit with segmentation faults before realizing that the
PolygonGeography()default constructor was creating a new object with an emptypolygon_pointer.This PR now creates a Polygon geography by default with an empty S2Polygon object, which I think is more predictable and more consistent with other geography types returning an empty container (vector) by default. However, I'm not sure how empty polygons are checked elsewhere here or in downstream libraries (R's s2?) ; if they explicitly check for
std::nullptr_tthen this is a breaking change.