Update CI: run tests with conda installed dependencies #4
Conversation
I've been pedantic here and enabled all kinds of warnings :-)
Add definitions that are also in s2geometry CMakeLists.txt.
Codecov ReportBase: 14.36% // Head: 14.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 14.36% 14.36%
=======================================
Files 14 14
Lines 1490 1490
Branches 29 29
=======================================
Hits 214 214
Misses 1270 1270
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Not just when building the tests (not required when building s2 from source).
|
Hmm not sure why we still have linking errors on Windows here. Another package that I maintain and that also depends on s2geometry has been built successfully on Windows with the last conda-forge s2 package: conda-forge/pys2index-feedstock#12. |
Global data symbols are missing in the conda-forge s2geometry windows shared library (more info: https://cmake.org/cmake/help/latest/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html). We'll probably need a new s2geometry conda-forge build with one more patch to manually add |
|
Sorry I haven't been of more help here! (The R windows package uses msys2/mingw/gcc, so I haven't run into these particular linking issues before). |
|
No worries! conda-forge/s2geometry-feedstock#10 will hopefully fix it. |
Force build to release to fix error similar to https://stackoverflow.com/a/27395888 (not sure what's happening). Use static linking (easier?). On Windows the GTest DLL (bundled build) is not found.
Switch to static linking (again) Build everything in Release mode, otherwise there's still this annoying SEH Exception: - Add `-config Release` to cmake build command for multi-config generators (e.g., MSVC) - Keep `CMAKE_BUILD_TYPE=Release` for single-config generators (e.g., make)
|
Windows / MSVC gave me some headache here but hopefully this will be helpful later, e.g., for packaging s2geography on conda-forge. The conda environment cache might be a bit overkill, I just wanted to try it (following steps from the setup-miniconda action documentation). It'll save some package downloads anyway. |
This PR adds a github workflow to build and run the tests on Linux / MacOS / Windows after installing dependencies with conda.