Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening MFXPopup based controls upwards #188

Open
gilad4 opened this issue Apr 27, 2022 · 4 comments
Open

Opening MFXPopup based controls upwards #188

gilad4 opened this issue Apr 27, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@gilad4
Copy link
Contributor

gilad4 commented Apr 27, 2022

I have noticed that controls which use MFXPopup (such as: MFXDatePicker, MFXComboBox, MFXFilterComboBox, etc.),
do not automatically open upwards when hitting the bottom screen, nor can it be done manually.

As can be seen in the demo, Legacy ComboBox does it automatically.

image

Doing it manually in a plain MFXPopup is possible but not very straight forward, still there's probably no way to reach it in the mentioned pickers without involving dirty code.

@palexdev
Copy link
Owner

Yes I'm well aware of the issue. Thanks for reminding me, I'll try to fix it for the next release

@palexdev palexdev added the bug Something isn't working label Apr 27, 2022
@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@gilad4
Copy link
Contributor Author

gilad4 commented Mar 16, 2023

Hi @palexdev,

Thank you for working on the issue. I appreciate your effort in trying to fix it.

However, the expected behavior is still not quite there. I would expect the popup to open upwards without covering the owner dropdown control, similar to how it works on the legacy controls. With the current change, the popup open upwards but still covers the owner control.

Let me know what you think.

@palexdev
Copy link
Owner

I don't know why though, I just flipped the JavaFX default switch, maybe it is the positioning algorithm, I have no clue honestly will see what I can do, but I don't assure you I can improve it further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants