fix: handle non-utf8 strings when printing exceptions

Fixes #66

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master
 
+- Fix logging non-UTF8 strings. ([@palkan][])
+
+  Fixes [#66](https://github.com/palkan/isolator/issues/66)
+
 ## 0.10.0 (2023-08-15)
 
 - Support multiple databases with DatabaseCleaner. ([@palkan][])

lib/isolator.rb

@@ -198,15 +198,23 @@ def connection_threshold(connection_id)
 
     def debug!(msg)
       return unless debug_enabled
-      msg = "[ISOLATOR DEBUG] #{msg}"
 
-      if backtrace_cleaner && backtrace_length.positive?
-        source = extract_source_location(caller)
+      separator = " ↳ "
 
-        msg = "#{msg}\n  ↳ #{source.join("\n")}" unless source.empty?
+      begin
+        msg = "[ISOLATOR DEBUG] #{msg}"
+        if backtrace_cleaner && backtrace_length.positive?
+          source = extract_source_location(caller)
+
+          msg = "#{msg}\n #{separator}#{source.join("\n")}" unless source.empty?
+        end
+
+        $stdout.puts(colorize_debug(msg))
+      rescue Encoding::CompatibilityError
+        should_retry = separator != " - "
+        separator = " - "
+        retry if should_retry
       end
-
-      $stdout.puts(colorize_debug(msg))
     end
 
     def extract_source_location(locations)

lib/isolator/notifier.rb

@@ -29,14 +29,22 @@ def send_notifications?
     def log_exception
       return unless Isolator.config.logger
 
-      msg = "[ISOLATOR EXCEPTION]\n" \
-            "#{exception.message}"
+      separator = " ↳ "
 
-      filtered_backtrace.each do |offense_line|
-        msg += "\n  ↳ #{offense_line}"
-      end
+      begin
+        msg = "[ISOLATOR EXCEPTION]\n" \
+              "#{exception.message}"
 
-      Isolator.config.logger.warn(msg)
+        filtered_backtrace.each do |offense_line|
+          msg += "\n #{separator}#{offense_line}"
+        end
+
+        Isolator.config.logger.warn(msg)
+      rescue Encoding::CompatibilityError
+        should_retry = separator != " - "
+        separator = " - "
+        retry if should_retry
+      end
     end
 
     def send_notifications

spec/isolator/notifier_spec.rb

@@ -73,6 +73,22 @@
             ↳ second/line/of/backtrace
         MSG
       end
+
+      context "when logging non-utf8 details" do
+        let(:exception) do
+          job_args = ["abc123", "\xff".dup.force_encoding(Encoding::ASCII_8BIT)] # rubocop:disable Performance/UnfreezeString
+          details = "MyJob (#{job_args.join(", ")})"
+
+          Isolator::HTTPError.new(details)
+        end
+
+        specify do
+          subject
+
+          expect(logger).to have_received(:warn).once
+          expect(logger).to have_received(:warn).with(%r{- first/line/of/backtrace})
+        end
+      end
     end
   end
 end