Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resque background job adapter #8

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Conversation

dsalahutdinov
Copy link
Contributor

No description provided.

@palkan
Copy link
Owner

palkan commented Feb 22, 2018

Cool! 👍

Let's update Readme and add a changelog entry.

@dsalahutdinov dsalahutdinov force-pushed the master branch 2 times, most recently from 7309d6b to bd96ac2 Compare February 22, 2018 09:22
@dsalahutdinov
Copy link
Contributor Author

dsalahutdinov commented Feb 22, 2018

Thank you for review. it's done

CHANGELOG.md Outdated
@@ -2,6 +2,10 @@

## master

## 0.2.0 (2018-02-22)

- [PR [#8](https://github.com/palkan/isolator/pull/8)] Add resque background job adapter.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding your nickname?)

@dsalahutdinov
Copy link
Contributor Author

dsalahutdinov commented Feb 22, 2018

I've added 😄 but I does not appears as link to my profile 😟
image

CHANGELOG.md Outdated
@@ -2,6 +2,10 @@

## master

## 0.2.0 (2018-02-22)

- [PR [#8](https://github.com/palkan/isolator/pull/8)] Add resque background job adapter. ([@dsalahutdinov][])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add the link itself to the end of file. It's just a reference

@dsalahutdinov dsalahutdinov force-pushed the master branch 2 times, most recently from c32198a to 2b38fd8 Compare February 23, 2018 09:57
@dsalahutdinov
Copy link
Contributor Author

done, sorry for stupidity 😸

@palkan palkan merged commit 2fe1a8b into palkan:master Feb 23, 2018
@palkan
Copy link
Owner

palkan commented Feb 23, 2018

Thanks! Released as 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants