Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destroy not deleting fx trigger file #249

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

tylerhunt
Copy link
Contributor

What is the purpose of this pull request?

Fix an issue where running rails d logidze:model doesn’t remove the fx trigger file since it was incrementing the trigger version and attempting the next version instead of the current version.

What changes did you make? (overview)

Updated the #next_version method to return the current version when the task behavior is :revoke.

Checklist

  • I've added tests for this change
  • I've added a Changelog entry
  • I've updated a documentation (Readme)

@palkan
Copy link
Owner

palkan commented Oct 23, 2024

Thanks!

@palkan palkan merged commit ed65e4c into palkan:master Oct 23, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants