-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Flask >= 2.2.0 #224
Conversation
0678a63
to
64e4a7b
Compare
If we're going to drop support for older versions of Flask I do prefer allowing 2.2+ vs 3.0+. Based on doing a lot of contract work, it may be surprising at how many folks are using older versions of Flask. One of the biggest Flask apps I've worked with (client) is still running 1.1. It has around ~500k lines of Flask / Python code. They use this extension but I think they would be fine sticking with the latest 0.14 release. One of the orgs I worked with recently was running 2.0 for a long time and recently upgraded to 3.0.
|
64e4a7b
to
08296cf
Compare
It doesn't surprise me. I've worked in the real world too. 😁 Agree it's a reasonable request, so I switched from As a consequence, |
08296cf
to
83a89d3
Compare
Let's hold off on merging this for a few weeks just to ensure our release of the Also IMO merging this will result in at least a |
Just to give us some confidence, I pulled 0.14.1 into a real Flask 3.0 project and it's all good. There are deprecation warnings to address which should still work with Flask 2.2.0. |
Nice, thanks for checking that! From what I can tell, this PR actually removes all usage of |
Require Flask >= `2.2.0`. I'm comfortable going up to requiring `3.x`, but when I grep'd for places we use older Flask constructs, this was all I found. So for now no need to jump further. Flask `2.2.0` requires Python >= `3.7`, so also dropped older pythons.
83a89d3
to
1c39a9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and cleans up nicely some things that we won't need.
Require Flask >=
2.2.0
.I'm comfortable going up to requiring
3.x
, but when I grep'd forplaces we use older Flask constructs, this was all I found.
So for now no need to jump further.
Flask
2.2.0
requires Python >=3.7
, so also dropped older pythons.I also dropped the Python 3.6 test from being required on the repo branch settings.
Fix #222