Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing whitespace #237

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix trailing whitespace #237

merged 1 commit into from
Apr 12, 2024

Conversation

jeffwidman
Copy link
Member

I noticed some trailing whitespace has crept into these files. It wasn't caught by pycodestyle because that only checks Python files.

Ideally we'd add a linter that catches these, but I didn't want to take the time to configure one right now, I just want my editor to stop flagging these while I'm working on trying to upgrade jquery versions.

Long term, we'll probably want a meta-linter like prettier or whatever the newest kid on the block is.

I noticed some trailing whitespace has crept into these files. It wasn't
caught by `pycodestyle` because that only checks Python files.

Ideally we'd add a linter that catches these, but I didn't want to take
the time to configure one right now, I just want my editor to stop
flagging these while I'm working on trying to upgrade `jquery` versions.

Long term, we'll probably want a meta-linter like `prettier` or whatever
the newest kid on the block is.
@jeffwidman jeffwidman enabled auto-merge (squash) April 12, 2024 16:25
@jeffwidman jeffwidman enabled auto-merge (squash) April 12, 2024 16:26
@jeffwidman jeffwidman merged commit 98bf17a into master Apr 12, 2024
10 checks passed
@jeffwidman jeffwidman deleted the fix-trailing-whitespace branch April 12, 2024 16:27
@macnewbold
Copy link
Contributor

I'd second the proposal of prettier - we've made it our standard at work and I've been quite happy with it. I'd also recommend looking at eslint as a way to handle all the things pycodestyle won't check.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants