chore(wip): Add typing #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add typing checks to the tox config with the requirements file to validate that the types are correct. An example in Flask would be https://github.com/pallets/flask/blob/main/tox.ini. It will also ensure that subsequent pull requests are compliant with type checking. |
aenglander
requested changes
Jul 15, 2024
| @@ -11,6 +11,9 @@ | |||
| """ | |||
|
|
|||
| from __future__ import with_statement | |||
| from typing import Optional | |||
| from typing import Callable | |||
| import typing_extensions | |||
There was a problem hiding this comment.
All tests are failing because they cannot find the typing_extensions library. It does not appear that the library was added to the dependencies. Also, look at what value this additional dependency adds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #69