Improve type hint (#1226)

CHANGES.rst

@@ -4,6 +4,7 @@ Version 3.0.5
 Unreleased
 
 -   ``Pagination.next()`` enforces ``max_per_page``. :issue:`1201`
+-   Improve type hint for ``get_or_404`` return value to be non-optional. :pr:`1226`
 
 
 Version 3.0.4

src/flask_sqlalchemy/extension.py

@@ -734,7 +734,7 @@ def get_binds(self) -> dict[sa.Table, sa.engine.Engine]:
 
     def get_or_404(
         self, entity: type[_O], ident: t.Any, *, description: str | None = None
-    ) -> t.Optional[_O]:
+    ) -> _O:
         """Like :meth:`session.get() <sqlalchemy.orm.Session.get>` but aborts with a
         ``404 Not Found`` error instead of returning ``None``.
 

tests/test_view_query.py

@@ -70,10 +70,11 @@ class Quiz(db.Model):
 
     db.create_all()
 
-    item: Quiz = Quiz()
+    item: Quiz = Quiz(topic="Python")
     db.session.add(item)
     db.session.commit()
     result = db.get_or_404(Quiz, 1)
+    assert result.topic == "Python"
     assert result is item
     if hasattr(t, "assert_type"):
         t.assert_type(result, Quiz)