1.0 version deprecations removal #484
Conversation
|
This library is definitely ready for 1.0. Although it would probably be a good idea to check if recaptcha still works, it seems like many of the issues are about that. |
|
recaptcha v2 still works correctly |
| "checked during processing instead." | ||
| ) | ||
| ) | ||
| return bool(self.data) |
There was a problem hiding this comment.
@azmeuk / @davidism So how does a user check whether the file field has data? The deprecation is a triple negative and I find it hard to understand 'data' is no longer set if the input is not a non-empty". That triple negative is hard to understand.
The bit in the documentation I can find from the change log https://flask-wtf.readthedocs.io/en/1.0.x/changes/#version-0-14-1 says:
"has_file is deprecated; it’s now equivalent to bool(field.data)."
As that's the only mention in the change log I can see, I presume I can write bool(field.data) still? Which sort of makes me wonder why remove the has_file() method?
html5 module is incompatible with wtforms 3, and its deprecation warning announce it will be remove for flask_wtf 1.0. So I suppose 1.0 is the next flask-wtf version in order to support wtforms 3.
@davidism what do you think?
Also, I do not have accesses to flask-wtf pypi to I cannot make the release myself at the moment.