-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MultipleFileField
and support validating multiple files
#556
Conversation
MultipleFileField
and support validating multiple fileMultipleFileField
and support validating multiple files
The failed style check is handled in #557. |
e7e38ff
to
a576c35
Compare
Not sure why the warnings from flask-babel are treated as errors: https://github.com/wtforms/flask-wtf/actions/runs/5623535426/job/15238419433?pr=556#step:6:129 |
This can be useful to force us to fix the deprecation warnings emitted by other libraries. However for this one there is not much that can be done on our side since the warning is emitted because of flask-babel: python-babel/flask-babel#230 Anyways, I checked your branch (with the flask-babel patch) and this looks all good to me 👌 |
@greyli you are maintainer, do you want to merge this PR or do you need other pairs of eyes to review it? |
Yes, I do want to merge this. Just went through all the changes again and fixed a typo in the docs. |
@greyli Do you think it this is ready to merge now? Do you want me to merge it and cut a release? |
- Add `MultipleFileField` field. - Update `FileRequired`, `FileAllowed`, and `FileSize` to make them work with multiple files. - Add tests for using Length with files field.
I think so. Thanks! |
Continue #338
MultipleFileField
field.FileRequired
,FileAllowed
, andFileSize
to make them work with multiple files.fixes #337
fixes #393
Checklist:
docs/changes.rst
summarizing the change and linking to the issue. Add.. versionchanged::
entries in any relevant code docs.