Teach Option to accept only explicit values #1230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to now, the logic for detecting an option value based on the remaining arguments on the command line has been handled inline in two different places. This refactor brings the two extremely similar procedures into one place, both for simplicity and to ease future changes.
Add a new attribute/argument `explicit_only` to `Option` class. When set
to true, this option will cause Options with nargs=1 to only accept
input that is explicitly associated to it.
This makes the following valid:
command
command --option
command --option=value
This addresses pallets#549 and pallets#764.
|
Thanks for working on this. While it's an interesting solution to the issue, I don't think we should be adjusting how the basic syntax works for individual options. Addressing this with #1618 instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new attribute/argument
explicit_onlytoOptionclass. When setto true, this option will cause Options with nargs=1 to only accept
input that is explicitly associated to it.
This makes the following valid:
This addresses #549 and #764.