Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing of default option value to handle empty strings #2724

Merged
merged 1 commit into from
May 21, 2024

Conversation

stefmolin
Copy link
Contributor

@stefmolin stefmolin commented May 20, 2024

Added an explicit check for the default value being an empty string to ensure that the default is displayed.

Fixes #2500

@stefmolin stefmolin marked this pull request as ready for review May 20, 2024 16:02
@aenglander aenglander added this to the 8.2.0 milestone May 20, 2024
@davidism davidism changed the base branch from main to 8.1.x May 21, 2024 16:24
@davidism davidism modified the milestones: 8.2.0, 8.1.8 May 21, 2024
@davidism davidism closed this May 21, 2024
@davidism davidism reopened this May 21, 2024
@davidism davidism merged commit d3e3852 into pallets:8.1.x May 21, 2024
13 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty string default values are not displayed
3 participants