fix color handling in test runner #2729
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
CliRunner.invoke()
, the isolation function was not mocking_compat.should_strip_ansi
in addition to the
utils.should_strip_ansi
. The_compat
version is only called when on Windows machines which is why it was missed. Also changed thetest_testing.py::test_with_color
to no longer skip when on windows. This will ensure that future changes to thetesting.py
modules will not cause a regression back to previous behavior.fixes #2705
Ensure each step in CONTRIBUTING.rst is complete, especially the following:
should fail without the change.
.. versionchanged::
entries in any relevant code docs.