-
-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project_urls so that PyPI will show GitHub stats. #2720
Conversation
Interesting, haven't seen that arg before. I see it was added to the setuptools docs, but there's no description of what keys are recognized. Is that documented somewhere? |
setup.py
Outdated
@@ -25,6 +25,11 @@ | |||
include_package_data=True, | |||
zip_safe=False, | |||
platforms='any', | |||
project_urls={ | |||
'Bug Tracker': 'https://github.com/pallets/flask/issues', | |||
'Documentation': 'http://flask.pocoo.org/', |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
No, I don’t think so. I found that my Authlib doesn’t have that GitHub section, and I wonder why. So I searched the code in warehouse, the logic is that it will detect GitHub repo by homepage and project_urls. Here is my log: lepture/authlib#45 I haven’t tested it. Maybe we can hold on this PR until I tested it with Authlib. |
I'll give it a try on a project when I get a chance too, and merge this before 1.0 if it works. |
Looks like it works fine, although I can't find the code in Warehouse that detects what URL to use for the GitHub stats. I changed to an |
And don't worry, I caught that I committed the wrong URLs. |
Current Flask in PyPI: https://pypi.org/project/Flask/
There is a "GitHub statistics" section, that is because the old homepage in setup.py is set to GitHub repo. But now, homepage url is replaced by pallets project page. When releasing a new version to PyPI, that section will go.
Warehouse can get the package's GitHub info from homepage url and project_urls. Let's add it back.