Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type hint fix for flask.send_file #5336

Merged
merged 1 commit into from
Nov 15, 2023
Merged

type hint fix for flask.send_file #5336

merged 1 commit into from
Nov 15, 2023

Conversation

dannyi96
Copy link
Contributor

@dannyi96 dannyi96 commented Nov 13, 2023 •
edited
Loading

Before
image

After
image

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change. --> NA
  • Add or update relevant docs, in the docs folder and in code. --> NA
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue -> i believe it's not needed ? let me know if otherwise
  • Add .. versionchanged:: entries in any relevant code docs -> NA
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@dannyi96
Copy link
Contributor Author

@davidism can you review this when possible ? thanks.

@davidism davidism changed the base branch from main to 3.0.x November 15, 2023 20:54
@davidism davidism added this to the 3.0.1 milestone Nov 15, 2023
@davidism davidism merged commit b97165d into pallets:3.0.x Nov 15, 2023
11 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidism davidism davidism approved these changes

Assignees
No one assigned
Labels
typing
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

flask.send_file() with Pylance in strict mode shows reportUnknownMemberType
2 participants
@dannyi96 @davidism