Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deploy.rst for better clarity #5601

Closed

Conversation

najasnake12
Copy link

I changed deploy.rst for better clarity specifically this part:
Before:
$ python -c 'import secrets; print(secrets.token_hex())'

'192b9bdd22ab9ed4d12e236c78afcb9a393ec15f71bbf5dc987d54727823bcbf'

After:
$ python -c 'import secrets; print(secrets.token_hex())'

Example secret key:
'192b9bdd22ab9ed4d12e236c78afcb9a393ec15f71bbf5dc987d54727823bcbf'

@ThiefMaster
Copy link
Member

I wonder whether we shouldn't simply blacklist that particular not-so-secret key, since I guess there's always a chance that people copy it instead of generating their own, even with that line message...

Also I don't think that adding this message is a good idea - this code block shows a shell command and its output, and that message you added is not part of the output.

@davidism davidism closed this Sep 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants