Sept 6th demo #5602
Closed
Sept 6th demo #5602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the entire site to follow Material design guidelines, providing a more modern look and feel. The font has been changed to 'Roboto' and 'Roboto Slab' for a cleaner typography. The color scheme has been adjusted to match the provided palette, enhancing the visual appeal and consistency across the site. Additional changes include: - Updated background and text colors for better contrast. - Added box shadows and border-radius for a softer appearance. - Improved button styling with hover effects for better interactivity. These changes aim to improve user experience by aligning with current design standards and making the interface more intuitive and visually appealing. Fixes #FLAS-4
Replace the previously used font in the style.css file with Roboto. The original font was not widely supported across different platforms and browsers, which could lead to inconsistent user experiences. By switching to Roboto, we ensure better compatibility and a more uniform appearance for users accessing the application.
This commit updates the font style in the file flaskr/static/style.css to include sans-serif. This change was made in response to a pull request review comment suggesting that the font should also be sans-serif. The update ensures consistency in the font style across the application, enhancing the overall visual appearance and readability.
Implemented dark mode across all pages, allowing users to toggle between light and dark themes. The default theme is determined by the operating system or browser settings. A toggle button in the navigation bar enables users to switch themes, using sun and moon icons from Font Awesome. User preferences are stored in cookies and local storage to ensure consistency across sessions and pages. The changes include: - Added a before_request function to load theme preference from cookies or set a default based on user agent. - Updated CSS to support dark mode styling. - Modified base.html to include a theme toggle button and corresponding JavaScript for theme switching. Fixes #FLAS-2
This commit addresses the issue of improper dark mode implementation. The background of all pages and form elements in dark mode were previously displayed in white, which has now been corrected. The background for input and textarea elements is set to a darker shade in dark mode, ensuring consistency with the overall theme. Additionally, the toggle button for switching themes has been redesigned to resemble iPhone-style toggles, replacing the previous square button. This enhances the user interface and provides a more intuitive experience when toggling between light and dark modes. Fixes #FLAS-3
This commit addresses the issue of incorrect dark mode icon placement in the toggle button. Previously, the moon and sun icons were displayed in the background, which was not the desired behavior. The icons are now correctly placed inside the circle of the toggle button. Changes include: - Updated CSS to center icons within the toggle button. - Adjusted HTML to ensure the correct icon is displayed based on the current theme. - Modified JavaScript to toggle icons appropriately when the theme changes. These changes improve the visual consistency and user experience of the dark mode toggle. Fixes #FLAS-5
This commit addresses the issue where the icon was incorrectly placed in the center of the toggle's background. The icon should be positioned inside the circle part that moves with the toggle. This change ensures that the icon moves along with the toggle, providing a more intuitive and visually consistent user experience.
This commit updates the font family in the file flaskr/static/style.css to FontAwesome as per the review comment. The previous font family was not rendering the icons correctly, leading to visual inconsistencies. By switching to FontAwesome, we ensure that the icons are displayed as intended. Additionally, the icon previously set in the background has been removed to avoid duplication and potential rendering issues. This change simplifies the styling and aligns with the reviewer's feedback.
|
This is not an acceptable way to interact with a public project. Use your own private fork to learn. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.