Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note about limitations of static files in blueprints #711

Closed
wants to merge 1 commit into from
Closed

Note about limitations of static files in blueprints #711

wants to merge 1 commit into from

Conversation

masklinn
Copy link

@masklinn masklinn commented Apr 9, 2013

Warn about issue 348's issue, at least until it is resolved.

Warn about issue 348's issue, at least until it is resolved.
@masklinn
Copy link
Author

masklinn commented Apr 9, 2013

#348

(had incorrectly linked the issue)

@ghost
Copy link

ghost commented Apr 10, 2013

-1. It already works correctly. There is nothing wrong in this behavior.
My proposal:

Default URLs are: / for the mount point and static/ for the static folder, relative to the mount point.
As a result, /static/ is the default blueprint static folder, and so it collides with the app static folder.

@masklinn
Copy link
Author

-1. It already works correctly.

That simply makes no sense: following the blueprint docs for static files will lead to the blueprint's static files not being available with no warnings. If the current behavior is desired, it should be noted and warned. If it's not, it should be fixed.

#348 is about the long term discussion of its fixing, this proposal is about warning about it in the meantime: the number of interventions on #348 shows the behavior is unexpected.

@ghost
Copy link

ghost commented Apr 11, 2013

There is nothing wrong in that behavior, but it is not documented. It would be nice to have that fact mentioned at http://flask.pocoo.org/docs/blueprints/#static-files and/or http://flask.pocoo.org/docs/api/#blueprint-objects

Citing from the bug.

@masklinn
Copy link
Author

Citing from the bug.

  1. that does not contradict what I wrote
  2. not everybody on Static files only work for blueprints registered with url_prefix #348 agrees that "there is nothing wrong in that behavior"

@ghost
Copy link

ghost commented Apr 11, 2013

Well, I'd just take a neutral position. But do what you want.

@masklinn masklinn deleted the patch-1 branch March 21, 2014 21:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants