Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async generators for python 3.5 #1058

Closed
maartenbreddels opened this issue Sep 2, 2019 · 2 comments
Closed

Async generators for python 3.5 #1058

maartenbreddels opened this issue Sep 2, 2019 · 2 comments

Comments

@maartenbreddels
Copy link

This packages provides async generators for Python3.5:
https://pypi.org/project/async_generator/

Is there interest in using this? Let's say if I open a PR, would that make a change of being merged?

@ecederstrand
Copy link

Either that, or python_requires in setup.py should be changed to not advertise Python 3.5 support. The jinja2.asyncfilters and jinja2.asyncsupport contain syntax errors when imported in Python 3.5.

@davidism
Copy link
Member

davidism commented Oct 8, 2019

Jinja does support Python 3.5. Async support is Python 3.6+. While the library is interesting, I don't want to add a required external dependency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants