Replaced execute preprocessor internals with nbclient calls #1211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #821. Took me a while to get around to it, but here's the PR with all the stuff moved into nbclient deleted.
I found that given how light the wrapper is now only a few very basic tests should be present. I didn't like how I had to subprocess NBClient's class to account for all the traitlet assignment junk, but it works and leave the interface backwards compatible. If nbclient ever needs to move it's interface forward or off trailets or whatever, we can capture it here for translation against future versions.