Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated Markup subclass #1401

Merged
merged 1 commit into from
Apr 18, 2021
Merged

fix deprecated Markup subclass #1401

merged 1 commit into from
Apr 18, 2021

Conversation

davidism
Copy link
Member

str subclass must override __new__ instead of __init__.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism
fix Markup subclass
e802be7 
str subclass must override __new__ instead of __init__
@davidism davidism merged commit 38839c7 into master Apr 18, 2021
@davidism davidism deleted the deprecated-markup branch April 18, 2021 01:39
@davidism davidism mentioned this pull request Apr 25, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markup.__init__ causes error
1 participant
@davidism