Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit curdir from PackageLoader root path #1505

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

davidism
Copy link
Member

@davidism davidism commented Oct 5, 2021

PackageLoader removes the current directory path segment after calling normpath. This fixes compatibility with loading from the root of zip imports.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

fixes compatibility with zip imports

Co-authored-by: kuepe-sl <peter_kueffner@web.de>
@davidism davidism added this to the 3.0.2 milestone Oct 5, 2021
@davidism davidism merged commit 28ef40c into 3.0.x Oct 5, 2021
@davidism davidism deleted the package-loader-path branch October 5, 2021 00:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant