Add missing environment options to the Environment.overlay method #1647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the options in sync with the options of the __init__ method.
Note: Please let me know if we want to be able to edit the 'enable_async' option also. I added this now
to streamline the overlay method options with the __init__ method, but perhaps there's no use-case for
changing this at runtime?
fixes #1645
Checklist:
There are no tests for previous individual arguments of the .overlay method, only a general test in
test_ext.py, so I also didn't add tests specifically for these options. I did test manually to verify the
options are set on the overlay, but unchanged on the original env. If requested, I can integrate these
into a seperate dedicated test for these options only
No changes required
CHANGES.rst
summarizing the change and linking to the issue.Looking at the format, this is only needed when a new version is released
.. versionchanged::
entries in any relevant code docs.No docs were changed
pre-commit
hooks and fix any issues.No issues found
pytest
andtox
, no tests failed.Pytest is a success. Please note the following errors are in the output of the tox command, but these
seem unrelated to the current change
Errors in tox output