Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stack cookies for C speedups #74

Closed
wants to merge 1 commit into from

Conversation

olivierbufalini
Copy link

No description provided.

Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work on windows too?

@davidism
Copy link
Member

Re: working on Windows, that appveyor failure doesn't mean anything, since it's not configured correctly right now, for some reason the appveyor for my fork picks up prs on the origin repo. :-/

So, we still need to know if this works on Windows.

@davidism davidism added this to the 1.1 milestone Apr 27, 2018
@davidism davidism mentioned this pull request Apr 27, 2018
@davidism
Copy link
Member

I'll rebase this in a bit, should trigger a new Windows build.

@methane
Copy link
Contributor

methane commented Apr 27, 2018

@olivierbufalini Why did you propose this?

_speedup.c doesn't use local buffer. I don't think there's no stack overflow.

@olivierbufalini
Copy link
Author

@methane have a look here : #73

@davidism davidism removed this from the 1.1 milestone May 3, 2018
@davidism
Copy link
Member

davidism commented May 3, 2018

Closing, please address the discussion in #73 first.

@davidism davidism closed this May 3, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants