fix spooled temporary file exceptions on file upload - 2 #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncojohnco
changed the title
|
Since the issue was only with Python 3's io implementation, you can skip the asserts on Python 2. Or maybe just try reading with |
|
Yay the tests are passing now 🎉 |
|
Rebased, added changelog, refactored tests. New test runs on Python 2 and 3, tests small and large files with and without |
abathur
referenced
this pull request
in coleifer/sqlite-web
Mar 23, 2019
Specifically, Flask (via werkzeug), uses a SpooledTemporaryFile to store the upload data. This file is opened in mode "wb+", which isn't compatible with the csv reader. TextIOWrapper can be used to translated the data, but the fucking SpooledTemporaryFile doesn't implement the fucking IOBase APIs. The issue is being bikeshedded by some assclown whose avatar is literally an ass: python/cpython#3249
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed behaviour of
FileStorage.__getattr__so that when there is an exceptionAttributeErrorto attempt to call theFileStorage.stream._file.{attr}if it existsResolves: #1344