Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set cache_control with none type #2398

Merged
merged 1 commit into from
Apr 25, 2022
Merged

set cache_control with none type #2398

merged 1 commit into from
Apr 25, 2022

Conversation

davidism
Copy link
Member

cache_control properties that had a None type weren't checking that before attempting to cast the value while setting. Another type issue came up in #2364, need to transition to using bool type for bool attributes.

fixes #2379

@davidism davidism added this to the 2.1.2 milestone Apr 25, 2022
@davidism davidism merged commit 19323ef into 2.1.x Apr 25, 2022
@davidism davidism deleted the cache-control-none branch April 25, 2022 13:56
@Yourun-proger
Copy link
Contributor

Glad it showed up.
Can I make the change mentioned in the pull request? I'm talking about "... transition to using bool type for bool attributes."

@davidism
Copy link
Member Author

I need to think about how to do the deprecation.

@Yourun-proger
Copy link
Contributor

Clear. Thanks

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@davidism @Yourun-proger