Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default max_form_memory_size to 500kB #2965

Merged
merged 1 commit into from
Oct 27, 2024
Merged

default max_form_memory_size to 500kB #2965

merged 1 commit into from
Oct 27, 2024

Conversation

davidism
Copy link
Member

We already use SpooledTemporaryFile to write file fields to disk after 500kB. Applying a 500kB limit to non-file form fields in memory is a reasonable default. Also expand the existing documentation about the limits available on Request.

fixes #2964

@davidism davidism added this to the 3.1.0 milestone Oct 27, 2024
@davidism davidism merged commit 0839766 into main Oct 27, 2024
12 checks passed
@davidism davidism deleted the max-memory branch October 27, 2024 21:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce reasonable defaults for critical config settings
1 participant