Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix #23

Conversation

wc117
Copy link
Contributor

@wc117 wc117 commented Aug 25, 2023

Related Github tickets

  • a list of github issues that are relevant for this PR

Background

A short paragraph on test what exactly this PR solves.

Testing completed

  • a list of actions that you've performed to ensure that this PR works as intended
  • 99% of the times you should have an item: "wrote tests"

@@ -187,7 +187,7 @@ def _safe_transfer_from(_token: address, _from: address, _to: address, _value: u
def send_token_to_paloma(token: address, receiver: String[64], amount: uint256):
_balance: uint256 = ERC20(token).balanceOf(self)
self._safe_transfer_from(token, msg.sender, self, amount)
_balance -= ERC20(token).balanceOf(self)
_balance = ERC20(token).balanceOf(self) - _balance
assert _balance > 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add error message here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Contributor

@webelf101 webelf101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taariq taariq merged commit ec0c6cc into palomachain:master Aug 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants