Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codeql action and config #1166

Merged
merged 2 commits into from
May 22, 2024

Conversation

maharifu
Copy link
Contributor

Add codeql github action and config based on cosmos-sdk config - https://github.com/cosmos/cosmos-sdk/blob/main/.github/workflows/codeql-analysis.yml

Related Github tickets

Background

Add a new github action to run CodeQL on the codebase. It add no functionality, so there are no tests and there should not be any breaking changes.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@maharifu maharifu force-pushed the lcarvalho/1476-codeql branch 2 times, most recently from da2b9e5 to c185a88 Compare May 20, 2024 16:02
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@maharifu maharifu force-pushed the lcarvalho/1476-codeql branch 3 times, most recently from 30f9926 to 74316e3 Compare May 21, 2024 08:40
@maharifu maharifu marked this pull request as ready for review May 21, 2024 13:42
@verabehr verabehr requested a review from byte-bandit May 21, 2024 14:05
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's already picked up quite a handful: https://github.com/palomachain/paloma/security/code-scanning?query=pr%3A1166+is%3Aopen

@verabehr I think it's worth creating a follow-up ticket to address the issues reported by this, especially around the panics, as these can lead to the infamous AppHash.

@verabehr
Copy link
Collaborator

ticket added here VolumeFi#1591

@taariq taariq merged commit 467bbdb into palomachain:master May 22, 2024
2 checks passed
@taariq taariq deleted the lcarvalho/1476-codeql branch May 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants