Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add relayer fee settings #1197

Merged
merged 10 commits into from
Jun 21, 2024
Merged

feat: add relayer fee settings #1197

merged 10 commits into from
Jun 21, 2024

Conversation

byte-bandit
Copy link
Contributor

@byte-bandit byte-bandit commented Jun 20, 2024 •
edited
Loading

Related Github tickets

Background

This change adds the concept of individual
relayer fees that may be set by any active
validator for any supported target chain.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

maharifu
maharifu requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@maharifu maharifu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Just a couple of nitpicks.

proto/palomachain/paloma/treasury/query.proto Outdated Show resolved Hide resolved
x/treasury/client/cli/tx.go Outdated Show resolved Hide resolved
x/treasury/client/cli/tx.go Outdated Show resolved Hide resolved
@byte-bandit
feat: add relayer fee settings
a48dc3c 
This change adds the concept of individual
relayer fees that may be set by any active
validator for any supported target chain.
maharifu
maharifu approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@maharifu maharifu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byte-bandit byte-bandit merged commit 4ff05b3 into palomachain:master Jun 21, 2024
4 checks passed
@byte-bandit byte-bandit deleted the feature/relayer-fees branch June 21, 2024 08:31
@taariq taariq mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maharifu maharifu maharifu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byte-bandit @maharifu