Enable performance based relayer selection #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
x/treasury/keeper/grpc_query.go
Outdated
Comment on lines
41
to
43
| for k := range i { | ||
| keys = append(keys, k) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
maharifu
reviewed
Jul 19, 2024
Co-authored-by: Luis Carvalho <mail.lmcarvalho@gmail.com>
Co-authored-by: Luis Carvalho <mail.lmcarvalho@gmail.com>
Co-authored-by: Luis Carvalho <mail.lmcarvalho@gmail.com>
Co-authored-by: Luis Carvalho <mail.lmcarvalho@gmail.com>
Comment on lines
+40
to
+42
| for key := range fees { | ||
| keys = append(keys, key) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Github tickets
Background
This change introduces fundamental changes to the relayer selection process. Live values are now gathered from the metrics module, and individual relayer fees are taken into account.
Going forward, it's paramount for relayers to make sure they have their fees set and configured for each chain, otherwise they will not be eligible for relaying anymore.
The majority of the changes are in
msg_assigner.go, that's where most of your attention will be needed. It works by collecting metric and fee data once per block for all validators and ranking them. Then each message during that block will be filtered depending on its requirements, and the top ranking eligible validator will be picked (and removed from the cache).They become eligible again next block. There are still some issues with this algorithm though. At the moment, the logic will prioritize the few top ranking validators only, with little way for the mid tier to rank up. This will need to be revisited in the future for sure.
Testing completed
Breaking changes