Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add legacy skyway message #1234

Conversation

maharifu
Copy link
Contributor

Related Github tickets

Background

We need these messages to be registered so they can be correctly unmarshalled, both on genesis import/export, as well as pruning the skyway attestation queue.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

We need these messages to be registered so they can be correctly
unmarshalled, both on genesis import/export, as well as pruning the
skyway attestation queue.
@taariq taariq requested a review from byte-bandit July 29, 2024 15:21
@maharifu maharifu marked this pull request as ready for review July 29, 2024 15:28
@maharifu maharifu merged commit f236733 into palomachain:master Jul 29, 2024
4 checks passed
@maharifu maharifu deleted the fix/1921-skyway-failed-to-prune-attestations branch July 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Skyway fails to prune attestation because of renamed messages
2 participants