Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fee skipping #1327

Merged
merged 1 commit into from
Jan 14, 2025
Merged

feat: add fee skipping #1327

merged 1 commit into from
Jan 14, 2025

Conversation

byte-bandit
Copy link
Contributor

@byte-bandit byte-bandit commented Jan 14, 2025

Related Github tickets

Background

This change introduces as custom TxFeeChecker implementation, which simply returns an empty fee for every transaction, as well as a constant priority.

Merging this change will lead to an equal transaction prioritization across Paloma, without the option to incentivize validators to include a transaction in an earlier block.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@byte-bandit byte-bandit requested a review from taariq January 14, 2025 14:37
@byte-bandit byte-bandit changed the title feat: fee skipper tx checker feat: add fee skipping Jan 14, 2025
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@taariq taariq merged commit 9091ad7 into palomachain:master Jan 14, 2025
4 checks passed
@taariq taariq deleted the clohr/fee-skip branch January 14, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants