Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for typed data in Datapayload #18

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Add support for typed data in Datapayload #18

merged 4 commits into from
Jul 5, 2023

Conversation

atimin
Copy link
Member

@atimin atimin commented Jul 3, 2023

Closes #

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md have been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Feature

What is the current behavior?

Currently, we can send only floats for scalar values because we use WaveletBuffer as a container. It doesn't work for flags, strings or big integers.

What is the new behavior?

In this PR, we introduce the TypedDataInfo structure in Meta Protocol, which can be used to decode serialized values in DataPayload for the following types:

Name ID Description
BOOL 0 Boolean
INT8 1 8-bit signed integer
UINT8 2 8-bit unsigned integer
INT16 3 16-bit signed integer
UINT16 4 16-bit unsigned integer
INT32 5 32-bit signed integer
UINT32 6 32-bit unsigned integer
INT64 7 64-bit signed integer
UINT64 8 64-bit unsigned integer
FLOAT32 9 32-bit float
FLOAT64 10 64-bit float
STRING 11 UTF-8 String

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

Other information:

@atimin atimin marked this pull request as draft July 3, 2023 16:00
@atimin atimin changed the title Add TypedDataInfo Add support for typed data in Datapayload Jul 4, 2023
@atimin atimin requested review from IngoKaiser and pmalessa July 4, 2023 11:22
@atimin atimin marked this pull request as ready for review July 4, 2023 11:22
docs/api/meta.md Outdated Show resolved Hide resolved
@atimin atimin merged commit 0248d35 into develop Jul 5, 2023
@atimin atimin deleted the typed-data branch July 5, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants