Sysinject hacks #1283
Draft
Sysinject hacks #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacraig2
reviewed
Feb 24, 2023
| let abe_callback = Callback::new(); | ||
| abe_callback.after_block_exec(move |cpu, _, _| { | ||
| if panda::current_asid(cpu) == injected_asid { | ||
| if !panda::in_kernel_mode(cpu) { |
There was a problem hiding this comment.
ASID//PC pair?```suggestion
if !panda::in_kernel_mode(cpu) {
lacraig2
reviewed
Feb 24, 2023
panda/plugins/sysinject_rs/README.md
Outdated
| `sysinject` allows for the injection of syscalls into the guest at arbitrary points. | ||
|
|
||
| The function `inject_syscall` takes 4 arguments | ||
| 1) `cpu`, the cpu state. This is standard for panda plugins. |
|
Check on MIPS issues |
|
… mess around with typecasting their args
lacraig2
reviewed
Mar 13, 2023
panda/plugins/sysinject/src/lib.rs
Outdated
|
|
||
| #[panda::init] | ||
| fn init(_: &mut PluginHandle) -> bool { | ||
| #[cfg(any(feature = "x86_64", feature = "aarch64", feature = "mips64", feature = "mipsl"))]{ |
There was a problem hiding this comment.
Classic mipsel misspell, oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything should be in order for 32 bit arm and x86 support. I left in the broken x86-64 code incase we want to do that in the future, so we have something to work off of, but I can remove it for neatness if need be.